search

aws-samples / aws-cudos-framework-deployment

Command Line Interface tool for Cloud Intelligence Dashboards deployment
https://catalog.workshops.aws/awscid
MIT No Attribution
399 stars 152 forks source link

cid-cfn.yml: Add validation on CFN parameter S3 bucket path #611

Closed nchicong closed 11 months ago

nchicong commented 1 year ago

Description of changes: Issue: Forgetting to put s3:// prefix OptimizationDataCollectionBucketPath would cost time to debug as the CFN stack deployed successfully but QuickSight dataset is empty due to the Athena table was not created.

This PR copies the validation from https://github.com/aws-samples/aws-cudos-framework-deployment/blob/main/cfn-templates/cid-cfn.yml#L118

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

iakov-aws commented 11 months ago

Merged! Thanks.