fix: activate SPLIT_COST_ALLOCATION_DATA option

aws-samples / aws-cudos-framework-deployment

Command Line Interface tool for Cloud Intelligence Dashboards deployment

https://catalog.workshops.aws/awscid

MIT No Attribution

400 stars 158 forks source link

Closed MaximF closed 4 months ago

MaximF commented 5 months ago

Issue #, if available:

Description of changes: Activate SPLIT_COST_ALLOCATION_DATA option

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

MaximF commented 5 months ago

@iakov-aws could you please take a look and let me know if that would be a good addition to your PR https://github.com/aws-samples/aws-cudos-framework-deployment/pull/794?

MaximF commented 4 months ago

@iakov-aws and @sean-nixon could you please take another look at this PR?

sean-nixon commented 4 months ago

Terraform code looks good to me. We'll just want to update the module README files to document the new variable.

MaximF commented 4 months ago

Thanks @sean-nixon! I just updated README files and also explicitly defined the variable type as bool. Take a look please.

MaximF commented 4 months ago

Great! Thank you for reviewing it @sean-nixon! @iakov-aws can we merge it today please?