search

aws-samples / aws-cudos-framework-deployment

Command Line Interface tool for Cloud Intelligence Dashboards deployment
https://catalog.workshops.aws/awscid
MIT No Attribution
372 stars 138 forks source link

add conditions for cur s3 policies #825

Closed iakov-aws closed 1 week ago

iakov-aws commented 4 weeks ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

iakov-aws commented 4 weeks ago

@sean-nixon can you have a look at TF part?

iakov-aws commented 3 weeks ago

I've left some inline comments, but at a higher level, all of these changes should be made to the cur-setup-destination module, not the cur-setup-source module.

Great feedback. Please can you approve the new version?

sean-nixon commented 1 week ago

@iakov-aws Let me know if I can do anything else to support this