search

aws-samples / aws-cudos-framework-deployment

Command Line Interface tool for Cloud Intelligence Dashboards deployment
https://catalog.workshops.aws/awscid
MIT No Attribution
400 stars 157 forks source link

New modules default values #863

Closed joegajeckyj closed 3 months ago

joegajeckyj commented 3 months ago

Hi,

Please can I request that you set default values to "no" for any new modules and updates that include new modules?

I am utilising the templates as a stackset and when you introduce new modules they are causing it to fail as I nee to pass the parameters in.

Cheers

iakov-aws commented 3 months ago

checking

iakov-aws commented 3 months ago

do you have some specific example? is it about cid-cfn or data collection?

joegajeckyj commented 3 months ago

''' { "ParameterKey": "pIncludeHealthEventsModule", "ParameterValue": "no" }, { "ParameterKey": "pIncludeAWSFeedsModule", "ParameterValue": "no" } '''

joegajeckyj commented 3 months ago

"https://${pCFNSourceBucket}.s3.amazonaws.com/cfn/data-collection/deploy-data-collection.yaml"

joegajeckyj commented 3 months ago

"https://${pCFNSourceBucket}.s3.amazonaws.com/cfn/data-collection/deploy-data-read-permissions.yaml"

IncludeHealthEventsModule

iakov-aws commented 3 months ago

ok i see it is in https://github.com/awslabs/cid-framework/ checking.

iakov-aws commented 3 months ago

https://github.com/awslabs/cid-framework/pull/152/files

iakov-aws commented 3 months ago

super curious what kind of automation you have in place

joegajeckyj commented 3 months ago

I have integrated with CfCT

iakov-aws commented 3 months ago

CfCT ?

joegajeckyj commented 3 months ago

Customizations for Control Tower

iakov-aws commented 3 months ago

Close as fixed. thanks for your feedback