search

aws-samples / aws-dynamodb-examples

DynamoDB Examples
MIT No Attribution
547 stars 216 forks source link

Java SDK-V2 adding Override Credentials Provider example code snippet… #108

Closed mslshao closed 8 months ago

mslshao commented 8 months ago

…, using PutItem

Issue #, if available: N/A - code sample.

Description of changes: This change was pulled (and modified) from this repository: https://github.com/mslshao/Override-IAM-Roles-per-DynamoDB-Request

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

tebanieo commented 8 months ago

The code looks good, we only have one small ask about the position. You are requesting this code to be a top level example, however all the rest of the Java code is under this folder can you please move your content there, and also don't forget to modify the README.MD and this other README.MD if required.

mslshao commented 8 months ago

Sure, I'll make the change and edit/update this PR. Thanks!

mslshao commented 8 months ago

~I definitely am not used to GitHub's way of doing forks/merges/rebasing, so... I apologize that this is in a double-commit.~ ~If there's a clean way to clean up the commit history, I'd appreciate it. Feel free to squash/rebase these commits when merging.~

EDIT: I fixed it. After rebasing, I had to git push --force to my own repository, to override the existing history.