Ability to select Security Group for existing VPC in config. step

aws-samples / aws-genai-llm-chatbot

A modular and comprehensive solution to deploy a Multi-LLM and Multi-RAG powered chatbot (Amazon Bedrock, Anthropic, HuggingFace, OpenAI, Meta, AI21, Cohere, Mistral) using AWS CDK on AWS

https://aws-samples.github.io/aws-genai-llm-chatbot/

MIT No Attribution

1.04k stars 311 forks source link

Ability to select Security Group for existing VPC in config. step #512

Open nkay28 opened 2 months ago

nkay28 commented 2 months ago

Enterprise customer doesn't allow PRIVATE_ISOLATED for ec2 SubnetType in their AWS account. So, need to pick the security group available in the existing VPC during the config step of deployment (Step 4), after changing PRIVATE_ISOLATED to PRIVATE_WITH_EGRESS in .ts files.

Facing following error during deployment: validation error detected: Value '[]' at 'vpcConfig.securityGroupIds' failed to satisfy constraint: Member must have length greater than or equal to 1 (Service: AmazonSageMaker; Status Code: 400; Error Code: ValidationException; Request ID: 0c2cdffd-07dc-4139-9f1c-3b9f4169c6aa...

massi-ang commented 1 month ago

@nkay28 I deployed the solution modifying the SubnetType here and here. I have also removed the PRIVATE_ISOLATED subnet from the VPC (commented out these lines ).

It deployed without issues.

nkay28 commented 1 month ago

Thanks @massi-ang. I tried with commenting out the last VPC component. It gave me a different error, with route tables this time:

CREATE_FAILED        | AWS::EC2::VPCEndpoint                           | SharedVPCS3GatewayEndpoint13AA3DEC
Resource handler returned message: "route table rtb-0913b605c41837278 already has a route with destination-prefix-list-id pl-63a5400a (Service: Ec2, Status Cod
e: 400, Request ID: 320b8cba-347e-4faf-aac0-21ff9d181020)" (RequestToken: 7373b475-22d8-623e-b330-447ea1c7ff9b, HandlerErrorCode: GeneralServiceException)

10:29:51 PM | CREATE_FAILED        | AWS::EC2::VPCEndpoint                           | SharedVPCDynamoDBEndpoint7FDC246D
Resource handler returned message: "route table rtb-0913b605c41837278 already has a route with destination-prefix-list-id pl-02cd2c6b (Service: Ec2, Status Cod
e: 400, Request ID: 01b71ac1-3325-40c2-beba-60011f4caa8a)" (RequestToken: 134dbee2-8e63-c45e-6d8e-84801f41b8c3, HandlerErrorCode: GeneralServiceException)

massi-ang commented 1 month ago

Can you please provide some more information about what modification you did? Ideally, can you provide a forked repo with your modifications so that it is simpler to reproduce the error

nkay28 commented 1 month ago

Hi @massi-ang,

Link to the repo fork with modifications: https://github.com/T-and-T-Consulting-Services-Inc/nih-aws-genai-llm-chatbot.git
3 commits ahead showing the modifications: https://github.com/aws-samples/aws-genai-llm-chatbot/compare/main...T-and-T-Consulting-Services-Inc:nih-aws-genai-llm-chatbot:main

Thank you for your continued guidance!