aws-samples / aws-genai-llm-chatbot

A modular and comprehensive solution to deploy a Multi-LLM and Multi-RAG powered chatbot (Amazon Bedrock, Anthropic, HuggingFace, OpenAI, Meta, AI21, Cohere, Mistral) using AWS CDK on AWS
https://aws-samples.github.io/aws-genai-llm-chatbot/
MIT No Attribution
1.09k stars 327 forks source link

npm run config fails reproducible (locally + Cloud9) with default settings #592

Open markusz opened 2 weeks ago

markusz commented 2 weeks ago

Running npm run config fails reproducible when following the deploy instructions.

I get the following error:

Could not complete the operation.
Cannot set properties of undefined (setting 'default')

I verified npm run config failing in different environments and configurations

Steps to reproduce:

  1. Clone the repository and checkout main. This will point to v3.1.3 of the aws-genai-llm-chatbot
  2. Follow the instructions for Cloud9 / local deployment
  3. Use default values for all inputs

image

markusz commented 2 weeks ago

v4.0.14 works, but main still points to v3.1.3, so this likely affects everyone following the deploy instructions in the docs

markusz commented 2 weeks ago

Workaround

charles-marion commented 2 weeks ago

Added a fix in #594

markusz commented 2 weeks ago

That was fast. Thanks!

yoavchaws commented 1 week ago

Well, when I run "npm run config" in Cloud9 in eu-central-1, selecting RAG with Knowledge base, it exits without asking me to save a config file and no config.json is created. Same with "npm run create". I suspect it is related to the change done to config.ts for this fix. 2024-10-24_09-41-02

charles-marion commented 1 week ago

@yoavchaws , I added a fix. Sorry about that.

yoavchaws commented 1 week ago

Thanks @charles-marion. The fix works fine. However, when I create a bedrock based RAG configuration, it does not ask me for the embedding model (embeddingModels[]) to use. As a result, the cdk bootstrap operation falls later with "no embedding model set". A work around is to change one of the embeddingModels[].default to true.

charles-marion commented 1 week ago

Added a fix in the PR https://github.com/aws-samples/aws-genai-llm-chatbot/pull/598 . Please use the work around listed above until merged.

charles-marion commented 5 days ago

Thank you for reporting the issue @yoavchaws , the change it merged.