fix s3 issue if deploying from region other than us-east-1

aws-samples / aws-genai-llm-chatbot

A modular and comprehensive solution to deploy a Multi-LLM and Multi-RAG powered chatbot (Amazon Bedrock, Anthropic, HuggingFace, OpenAI, Meta, AI21, Cohere, Mistral) using AWS CDK on AWS

https://aws-samples.github.io/aws-genai-llm-chatbot/

MIT No Attribution

1.1k stars 332 forks source link

fix s3 issue if deploying from region other than us-east-1 #603

Open arief-hidayat opened 2 weeks ago

arief-hidayat commented 2 weeks ago

Issue #, if available: encounter S3 issue when deploying from ap-southeast-3 (other than us-east-1), such as CORS.

Description of changes: follow recommendation from https://aws.amazon.com/blogs/media/deep-dive-into-cors-configs-on-aws-s3-how-to/

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

charles-marion commented 1 week ago

Hi @arief-hidayat ,

Thank you for the update! (and sorry for the late follow up) Can you clarify what is the issue in other regions (or error you got)?

The use of s3v4 was already set for all pre-signed URLs (which is when CORS would matter). (And the SDK automatically sets the current region)

That being said I don't see a downside of this change since v4 is the current version