aws-samples / aws-health-aware

AHA is an incident management & communication framework to provide real-time alert customers when there are active AWS event(s). For customers with AWS Organizations, customers can get aggregated active account level events of all the accounts in the Organization. Customers not using AWS Organizations still benefit alerting at the account level.
MIT No Attribution
348 stars 143 forks source link

Multi-Region deployment fails to create all lambda environment variables #22

Closed mfazz closed 4 months ago

mfazz commented 3 years ago

When deploying AHA in multi-region mode, I am getting the error:

[ERROR] KeyError: 'ACCOUNT_IDS'
Traceback (most recent call last):
  File "/var/task/handler.py", line 872, in main
    describe_org_events(health_client)
  File "/var/task/handler.py", line 734, in describe_org_events
    if os.environ['ACCOUNT_IDS'] == "None" or os.environ['ACCOUNT_IDS'] == "":
  File "/var/lang/lib/python3.8/os.py", line 675, in __getitem__
    raise KeyError(key) from None

Looking at cloudformation, it appears the line starting below doesn't create ACCOUNT_IDS as an environment variable for the secondary region - https://github.com/aws-samples/aws-health-aware/blob/06229f14e41c0ab5b71f66f68f1b33db48aa7d05/CFN_DEPLOY_AHA.yml#L408

jordanaroth commented 2 years ago

Taking a look at this.

andrewcr7 commented 4 months ago

Reviewed, Jordan resolved the issue here and in Issue #37

Will close this one