search

aws-samples / aws-iam-access-key-auto-rotation

This set of CloudFormation templates and Python scripts will set up an auto-rotation function that will automatically rotate your AWS IAM User Access Keys every 90 days.
MIT No Attribution
134 stars 128 forks source link

code is not good enough for testing #7

Closed sidharthsinghcfins closed 2 years ago

sidharthsinghcfins commented 2 years ago

Issue 1: This function seems to update secrets manager only in plaintext format not in key pair format. Issue 2: if there is already an entry for user in key value pair in secrets manager , (let say when user is created via CF and updated to SM). those keys are not updated at all.

in both scenarios keys gets rotated and i get notification., but there is not key update on secrets manager. i can confirm there is gap in the code and is partially running to even test for test scenarios. gap in this solution is implementation and how console or aws handles secrets in json format.

aws-laura commented 2 years ago

Issues 1 & 2 have been resolved with the new version 2 release.