search

aws-samples / aws-iam-identity-center-extensions

This solution is intended for enterprises that need a streamlined way of managing user access to their AWS accounts. Using this solution, your identity and access management teams can extend AWS SSO functionality by automating common access management and governance use cases
MIT License
65 stars 24 forks source link

Typo in Json Schema #97

Closed debojitmegaco closed 2 years ago

debojitmegaco commented 2 years ago

https://github.com/aws-samples/aws-sso-extensions-for-enterprise/blob/6911cbed332710ae164807e06686c11620f372d8/lib/payload-schema-definitions/Link-S3.json#L31

Currently the Json Schema for "pattern": "account\\d{12}%[\\w+=,.@-]{1,32}%[_\\-\\p{L}\\p{M}\\p{S}\\p{N}+@.]{1,128}%USER%ssofile" has a typo and missing delimeter %

debojitmegaco commented 2 years ago

@leelalagudu, Have submitted a Pull request for the Json Schema Update https://github.com/aws-samples/aws-sso-extensions-for-enterprise/pull/98

leelalagudu commented 2 years ago

Hi @debojitmegaco , thank you for the PR. I had reviewed and approved the changes, however I don't have merge permissions. @jmejco / @tamara-h would be able to do this when they have some free time

jmejco commented 2 years ago

Closed by https://github.com/aws-samples/aws-sso-extensions-for-enterprise/pull/98