search

aws-samples / aws-iot-securetunneling-localproxy

AWS Iot Secure Tunneling local proxy reference C++ implementation
https://docs.aws.amazon.com/iot/latest/developerguide/what-is-secure-tunneling.html
Apache License 2.0
73 stars 69 forks source link

No support for boost version 1.78 statement #115

Closed thomas-roos closed 1 year ago

thomas-roos commented 1 year ago

Describe the bug No support for boost version 1.78 - is this correct?

yocto kirkstone does only have Boost 1.78 included EOL is 2024 (https://wiki.yoctoproject.org/wiki/Releases)

By changing / patching this line it also compiles https://github.com/aws-samples/aws-iot-securetunneling-localproxy/blob/989c1be67d164558376c738e0d64ba5983502220/CMakeLists.txt#L78

Question - are there issues known with 1.78? Can you just change this requirement?

RogerZhongAWS commented 1 year ago

Hello @thomas-roos . If boost 1.78 works, you are welcome to keep using it via your modified CMake file. What we were trying to do here is specify the latest known version that has been built and tested, while at the same time giving people the freedom to set their own boost version as a manual override with the expectation that it may not always work.

I also recognize the fact that this does not stop CMake from finding newer versions of boost (such as 1.81), since the default behavior of find_package is to find the lowest compatible version equal to a greater than the specified version. Because 1.81 does not work and 1.78 does, I do find this behavior incongruous with what Cmake expects. I can fix that by passing in the EXACT param into find_package, which will make it require that version number exactly.

thomas-roos commented 1 year ago

Hi, I think in this case, a patch on the Yocto side (for just this specific release branch) is might ok to carry around. What is more crucial is the other boost 1.81 fix - it's very unlikely that the boost team is bringing back old behavior - so it's just a matter of time till everybody will struggle... as said already. Thank you!