Add BUILD_TESTS option to cmake and downgrade dependency versions

[jimmylomro]

Motivation

• Please give a brief description for the background of this change: this adds the ability to build without tests and also to not build dependencies from source (use apt dev packages)

• Issue number: NA

Modifications

Change summary

Please describe what changes are included in this pull request:

• Changed set_property for set to set the variable Boost_USE_STATIC_LIBS, the set_property method does not choose the static libraries correctly if the dynamic versions exist (possibly because scope issues of the method and the fact that Boost uses if(DEFINED Boost_USE_STATIC_LIBS) to test for the variable). This can be verified with cmake -DBoost_DEBUG=ON ../
• CMakeLists.txt adds an option BUILD_TESTS (defaults to ON) so that the user can compile using cmake -DBUILD_TESTS=OFF ../ && make, which prevents the necessity for Catch2.
• The dependency versions for Protobuf and Boost have been downgraded to the most recent versions available with apt install libboost-all-dev libprotobuf-dev (on ubuntu 22.04 x86_64), this allows the user to skip the source build of all dependencies and use the available dev packages:

  sudo apt install zlib1g-dev libboost-all-dev libssl-dev libprotobuf-dev protobuf-compiler
  mkdir build && cd build
  cmake -DBUILD_TESTS=OFF ../
  make

Revision diff summary

If there is more than one revision, please explain what has been changed since the last revision.

Testing

Is your change tested? If not, please justify the reason.: I did not test because only the method changed Please list your testing steps and test results.

• CI test run result:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[jimmylomro]

Second commit adds an install directive and a couple of explicit includes. These includes might be available on newer versions of Boost or Protobuf headers, but on the downgraded versions they seem to not be included.

Also in case this is useful, the oldest breaking change in Protobuf happened in version v3.4.0 (introduction of ByteSizeLong method), and the latest breaking change in Boost is the introduction of the beast library in 1.66.0. So these are possibly the oldest REQUIRED versions of these packages.

[RogerZhongAWS]

Hello! Thank you for doing the research and for making this change. We recently released a new version of the localproxy, so we will need to test these older dependency versions with the updated source code. Please hang tight.

Regards, Roger

[RogerZhongAWS]

May I suggest we set the package version as a property and parameterize it like this? Instead of: find_package(Protobuf 3.6.1 REQUIRED) We do: set_property(GLOBAL PROPERTY PROTOBUF_PKG_VERSION 3.17.3) find_package(Protobuf ${PROTOBUF_PKG_VERSION} REQUIRED)

and same thing for boost respectively.

That way, we can update our documentation to say setting -DPROTOBUF_PKG_VERSION is up to the user but not guaranteed to work past a certain version.