search

aws-samples / aws-iot-twinmaker-samples

Apache License 2.0
97 stars 77 forks source link

feat(Fix-cookiefactoryv2): Fixed the unused/misconfigured data in coo… #109

Closed divya-sea closed 1 year ago

divya-sea commented 1 year ago

Description of changes: We discovered some unused and incorrectly configured data during the bug bash To be more accurate, some data needs to be removed from the json file.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

intpix commented 1 year ago

@divya-sea there seem to be two commits in which the second reverts the scene.json changes of the first. also, the scene.json in the first commit won't load when testing in the console.

Screenshot 2023-05-11 at 8 48 28 AM

divya-sea commented 1 year ago

Fixed this issue in this cr - https://github.com/aws-samples/aws-iot-twinmaker-samples/pull/109/commits/abb69a1a3e2e7289bc4c0b7e630d3103abf1453c

intpix commented 1 year ago

i tested that version, too, and the mixer tags are still in the scene.

Screenshot 2023-05-11 at 1 05 45 PM

i've been adding some test overlays to the scene in the meantime. would it make things easier if i just removed the mixer tags along with that work?

intpix commented 1 year ago

Already fixed this issue in my subsequent commit.