search

aws-samples / aws-iot-twinmaker-samples

Apache License 2.0
97 stars 77 forks source link

create sts client by existing session #24

Closed CrazyShipOne closed 2 years ago

CrazyShipOne commented 2 years ago

Issue #, if available:

23

Description of changes: Using existing session rather than a new boto3 instance.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

johnnyw-aws commented 2 years ago

Hi CrazyShipOne,

Thanks for the fix! Change looks good to me but just wanted to double-check: I noticed your author email in the commit was a little unusual, just wanted to verify that it was correct before I merge your commit in:

commit 3453f5197417de1ee42419e5edccb256809c2e97
Author: <email> <[random-characters]>
Date:   Thu Feb 10 14:33:19 2022 +0800

    create sts client by existing session
CrazyShipOne commented 2 years ago

Hi @johnnyw-aws,

My bad, just forgot to config user info on the new working laptop...I created a new pr request #26 with correct author information.

Thanks for notifying.

johnnyw-aws commented 2 years ago

Closing as duplicate of https://github.com/aws-samples/aws-iot-twinmaker-samples/pull/26

Thanks CrazyShipOne for your contribution!