search

aws-samples / aws-marketplace-serverless-saas-integration

Example of serverless integration for SaaS products listed on the AWS Marketplace.
MIT No Attribution
127 stars 73 forks source link

SAM deployment fails when `CreateRegistrationWebPage` is set to `false` #53

Closed gargana closed 2 years ago

gargana commented 2 years ago

Describe the bug When parameter CreateRegistrationWebPage is set to false deployment fails due to the fact that the Output - LandingPageUrl references CloudfrontDistribution which is only created when CreateRegistrationWebPage is true .

To Reproduce Deploy the app with CreateRegistrationWebPage set to false

Expected behavior The stack will fail complaining about an unresolvable reference

Screenshots If applicable, add screenshots to help explain your problem. Screen Shot 2022-08-17 at 11 15 00 AM

Desktop (please complete the following information): n/a

Smartphone (please complete the following information): n/a

Additional context Add any other context about the problem here.

gargana commented 2 years ago

Fix merged