search

aws-samples / aws-modern-application-workshop

A tutorial for developers that want to learn about how to build modern applications on top of AWS. You will build a sample website that leverages infrastructure as code, containers, serverless code functions, CI/CD, and more.
Apache License 2.0
1.46k stars 832 forks source link

Missing "-" on the repository ARN #150

Open alanwang76 opened 4 years ago

alanwang76 commented 4 years ago

There was a typo in the policy of role MythicalMysiftsServiceCodeBuildServiceRole. It should be:

"Resource": [ "arn:aws:codecommit:us-east-1:300745402581:MythicalMysfitsService-Repository" ],

It does't have the "-". But the CodeCommit repository is named as MythicalMysfitsService-Repository with the "-".

dstroppa commented 4 years ago

Hi @alanwang76, what version of the workshop does this issue refers to?

alanwang76 commented 4 years ago

It's Python.

Sent by Outlookhttps://aka.ms/qtex0l for iOS

From: Daniele Stroppa notifications@github.com Sent: Monday, November 4, 2019 5:07:30 AM To: aws-samples/aws-modern-application-workshop aws-modern-application-workshop@noreply.github.com Cc: alanwang76 alanwang@outlook.com; Mention mention@noreply.github.com Subject: Re: [aws-samples/aws-modern-application-workshop] Missing "-" on the repository ARN (#150)

Hi @alanwang76https://github.com/alanwang76, what version of the workshop does this issue refers to?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/aws-samples/aws-modern-application-workshop/issues/150?email_source=notifications&email_token=ANQVWIARJ72KUWB3UC2LJP3QSANBFA5CNFSM4JIHW65KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC7FN4A#issuecomment-549345008, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANQVWIAU7U634MNZQNHJFKTQSANBFANCNFSM4JIHW65A.