search

aws-samples / aws-modern-application-workshop

A tutorial for developers that want to learn about how to build modern applications on top of AWS. You will build a sample website that leverages infrastructure as code, containers, serverless code functions, CI/CD, and more.
Apache License 2.0
1.46k stars 832 forks source link

Update Dockerfile #239

Closed gjmveloso closed 3 years ago

gjmveloso commented 3 years ago

Use MCR as workaround for Docker Hub pull images limits

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

abaird986 commented 3 years ago

Hi, thanks for submitting this. Can you provide some more context for my review on why the change is needed? I'm not a .NET developer and need a bit more color to guide my review. Thanks!

abaird986 commented 3 years ago

I see the reason for the submission now, not .NET-centric, after reviewing your other PRs. Closing this one for now too, but will re-open and merge if we decide its something we'd like to address. Thanks again for bringing this to our attention!