aws-samples / aws-modern-application-workshop

A tutorial for developers that want to learn about how to build modern applications on top of AWS. You will build a sample website that leverages infrastructure as code, containers, serverless code functions, CI/CD, and more.
Apache License 2.0
1.46k stars 832 forks source link

Changes to support both Fargate and EC2 #248

Closed pedroprieto closed 3 years ago

pedroprieto commented 3 years ago

Issue #, if available: Issue #186 Pull #217

Add support for both EC2 and Fargate. The instructions have been updated to offer both options. So, you can now deploy the ECS Service from module 2 both in regular and starter (student) AWS accounts.

Changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

abaird986 commented 3 years ago

I appreciate the work here, but we'd prefer not to have the instructions fork within the modules. Perhaps we can consider these changes taking the form of their own separate branch. Can you give me some more background on the starter/student accounts? Does this work around restrictions that prevent use of the other services?

pedroprieto commented 3 years ago

Hi,

Perfectly understandable.