search

aws-samples / aws-panorama-samples

This repository has samples that demonstrate various aspects of AWS Panorama device and the Panorama SDK
https://docs.aws.amazon.com/panorama/
MIT No Attribution
82 stars 59 forks source link

Implemented read a frame at a time. End of video frame handled. [Feature Add] #26

Closed shaanrockz closed 2 years ago

shaanrockz commented 2 years ago

Issue #, if available:

  1. Loading large number of frames in one shot from the video on restrictive memory could be fatal.
  2. End of frame sequence exception unhandled.

Description of changes:

  1. Added generator mechanism to read a frame at a time (low on memory)
  2. Handled StopIteration exception

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

shimomut commented 2 years ago

Hi @shaanrockz , thank you for your pull-request. This issue was one of what we were planning to fix soon, but haven't started. We will review your change. Thank you!

shimomut commented 2 years ago

Reviewed the contents and confirmed the behavior. Merged. Thank you for your contribution!