search

aws-samples / aws-saas-factory-eks-saas-workshop

MIT No Attribution
53 stars 23 forks source link

Minor fix request for the workshop #7

Closed jimini55 closed 1 year ago

jimini55 commented 2 years ago

I have found a couple of minor bugs.

[1] File name fix required Guide link: https://catalog.us-east-1.prod.workshops.aws/v2/workshops/56ef6f79-74e2-4710-aefb-10b9807057a9/en-US/data-types/basics/declaring

Step 6. the file link should be fixed.

services/shared/apps/tenant-registration/src/registration/registration-service.ts -> services/shared/apps/tenant-registration/src/registration/registration.service.ts

[2] Guide link: https://catalog.us-east-1.prod.workshops.aws/v2/workshops/e04c0885-830a-479b-844b-4c7af79697f8/en-US/lab-4/6-apply-network-policy#step-10-install-tigera-calico

Step 10. When I installed calico, the command did not work, having 404 error.
kubectl apply -f https://raw.githubusercontent.com/aws/amazon-vpc-cni-k8s/master/config/v1.6/calico.yaml

I tried below two commands instead and worked well. 

kubectl apply -f https://raw.githubusercontent.com/aws/amazon-vpc-cni-k8s/master/config/master/calico-operator.yaml
kubectl apply -f https://raw.githubusercontent.com/aws/amazon-vpc-cni-k8s/master/config/master/calico-crs.yaml

I refered to the official doc: https://docs.aws.amazon.com/eks/latest/userguide/calico.html

Thank you for great contents. Cheers!

ranjith-aws commented 2 years ago

Thanks for reporting @jimini55 . We will check and get this addressed.

ivorscott commented 2 years ago

@jimini55 Thank you. This worked for me.

tobuck-aws commented 1 year ago

We removed Calico entirely from the workshop in lieu of Istio. Closing this comment as not applicable anymore.