search

aws-samples / aws-sagemaker-build

Creates a CloudFormation template that uses AWS StepFunctions to automate the building and training of Sagemaker custom models based on S3 and GitHub events
Apache License 2.0
165 stars 44 forks source link

Script fails due to Node.js deprecated version #17

Closed sstoeckel closed 5 years ago

sstoeckel commented 5 years ago

The CFN script receives an CREATE_FAILED du to Nodejs 6..10 deprectation for lambda:

The runtime parameter of nodejs6.10 is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs8.10) while creating or updating functions. (Service: AWSLambdaInternal; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: 219305e6-762d-11e9-876c-156d067a48cc)
  | 11:46:21 UTC+0200 | CREATE_FAILED | AWS::Lambda::Function | FailLambda

Therefore npm run up fails with the following:

SageBuild-test-1
Waiting on stack:SageBuild-test-1
✖ SageBuild-test-1:CREATE_FAILED
(node:50395) UnhandledPromiseRejectionWarning: CREATE_FAILED
(node:50395) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:50395) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
JohnCalhoun commented 5 years ago

working on the fix right now

JohnCalhoun commented 5 years ago

there is a fix in the dev branch, need to finish up some testing before pushing to master

JohnCalhoun commented 5 years ago

fixed in latest master branch