search

aws-samples / aws-sdk-js-notes-app

A simple note taking application using modular AWS SDK for JavaScript (v3)
Other
81 stars 28 forks source link

feat(deps): bump vite to 3.2.5 #65

Closed trivikr closed 1 year ago

trivikr commented 2 years ago

Issue

Vite 3.0 is out https://vitejs.dev/blog/announcing-vite3.html

Description

Bumps vite to 3.0.0

Testing

ToDo: Local testing

Additional context

Migration Guide https://vitejs.dev/guide/migration.html

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

trivikr commented 1 year ago

Following error is thrown in browsers:

Uncaught Error: Module "events" has been externalized for browser compatibility. Cannot access "events.EventEmitter" in client code.
    at Object.get (browser-external:events:9:13)
    at ../../node_modules/readable-stream/lib/_stream_readable.js (_stream_readable.js:32:10)
    at __require2 (chunk-ACCAMVX6.js?v=fb47731b:18:50)
    at ../../node_modules/readable-stream/readable-browser.js (readable-browser.js:1:28)
    at __require2 (chunk-ACCAMVX6.js?v=fb47731b:18:50)
    at ../../node_modules/microphone-stream/dist/microphone-stream.js (microphone-stream.js:19:25)
    at __require2 (chunk-ACCAMVX6.js?v=fb47731b:18:50)
    at dep:microphone-stream:1:16

react-dom.development.js:18687 The above error occurred in the <LocationProvider2> component:

    at LocationProvider2 (http://localhost:5173/node_modules/.vite/deps/@reach_router.js?v=950a7a4a:590:5)
    at Location2 (http://localhost:5173/node_modules/.vite/deps/@reach_router.js?v=950a7a4a:581:23)
    at Router2
    at Suspense
    at div
    at Routes
    at div

Consider adding an error boundary to your tree to customize error handling behavior.
Visit https://reactjs.org/link/error-boundaries to learn more about error boundaries.
trivikr commented 1 year ago

Errors were fixed by polyfills events and util

Ref: https://github.com/vitejs/vite/issues/9238#issuecomment-1190886783