search

aws-samples / aws-sdk-js-notes-app

A simple note taking application using modular AWS SDK for JavaScript (v3)
Other
82 stars 32 forks source link

Building backend throws "Subsequent property declarations must have the same type" error #77

Closed trivikr closed 1 year ago

trivikr commented 2 years ago

Describe the bug

The command yarn build:backend throws "Subsequent property declarations must have the same type" error

Steps to reproduce

Run yarn build:backend

Observed behavior

Following error is thrown:

../../node_modules/@types/react/index.d.ts:3317:13 - error TS2717: Subsequent property declarations must have the same type.  Property 'tspan' must be of type 'SVGProps<SVGTSpanElement>', but here has type 'SVGProps<SVGTSpanElement>'.

3317             tspan: React.SVGProps<SVGTSpanElement>;
                 ~~~~~

  ../../node_modules/@types/reach__router/node_modules/@types/react/index.d.ts:3167:13
    3167             tspan: React.SVGProps<SVGTSpanElement>;
                     ~~~~~
    'tspan' was also declared here.

Expected behavior

Build for backend successful.

trivikr commented 2 years ago

This appears to be an issue with reach router. It would be fixed on moving to React Router 6 in https://github.com/aws-samples/aws-sdk-js-notes-app/pull/60

trivikr commented 1 year ago

The error is no longer thrown on running yarn build:backend

The lock file maintenance PR in https://github.com/aws-samples/aws-sdk-js-notes-app/pull/76 would have fixed it.