search

aws-samples / aws-secret-sidecar-injector

Kubernetes mutating webhook to fetch secrets from AWS Secrets Manager
MIT No Attribution
145 stars 35 forks source link

add ability for multiple secrets #20

Closed danquack closed 4 years ago

danquack commented 4 years ago

Issue #, if available: closes #13

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

danquack commented 4 years ago

If you think a different name is better that's cool too. Just try to keep it as minimal as possible, but open to suggestions if you want. Opening a PR to another branch is super easy too!

jicowan commented 4 years ago

I need to think about it. I opened an issue (help wanted) for a user defined file name. That would probably be the best thing here. The developer could specify it as another (optional) annotation.

danquack commented 4 years ago

Would you expect that as acceptance criteria for this issue, or a future request

jicowan commented 4 years ago

@danquack No, I don't think the user-defined filename is required to accept this PR. We can handle that separately. That said, I would like to create a separate branch for the multiple secrets, at least until we've pushed the code for the controller that handles the rotation of secrets. Thanks for your work on this.

danquack commented 4 years ago

@jicowan can you let me know what branch you want me to send this to then instead?

jicowan commented 4 years ago

@danquack I created a branch called multi-secret.

danquack commented 4 years ago

Reopened as #22

ranmeekkhsc commented 4 years ago

is admission controller able to handle Secret_ARN as array as of now ?

jicowan commented 4 years ago

@danquack created a separate branch that allows you to reference multiple secrets. We will likely merge it into the mainline after releasing the logic for rotating secrets.