search

aws-samples / aws-secrets-manager-rotation-lambdas

Contains Lambda functions to be used for automatic rotation of secrets stored in AWS Secrets Manager
MIT No Attribution
329 stars 282 forks source link

Add support 'aurora-postgres' engine #107

Closed creatorKoo closed 1 year ago

creatorKoo commented 1 year ago

Issue #, if available:

Description of changes: If you using Aurora postgresql then rds api return engine to 'aurora-postgres'. So, I change code to check logic 'exact match' to 'contain match'.

It works well. I'm glad to additional suggest.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

adithyasolai commented 1 year ago

@creatorKoo

Thank you for bringing this to our attention.

We are working on appropriately prioritizing development on this issue.

creatorKoo commented 1 year ago

@creatorKoo

Thank you for bringing this to our attention.

We are working on appropriately prioritizing development on this issue.

ok i will wait for patch

jbct commented 1 year ago

Closing this as it was resolved as a part of https://github.com/aws-samples/aws-secrets-manager-rotation-lambdas/commit/196703e8323533f98fdf6f9c7b5503e69a171b12.