aws-samples / aws-secrets-manager-rotation-lambdas

Contains Lambda functions to be used for automatic rotation of secrets stored in AWS Secrets Manager
MIT No Attribution
329 stars 282 forks source link

RotationMultiUser doesn't set host and engine from masterSecret #84

Closed ahammond closed 2 years ago

ahammond commented 2 years ago

I added password rotation to my database using https://github.com/time-loop/cdk-aurora/blob/main/src/aurora.ts#L284

However, it didn't

Also, what is with the master stuff? BLM happened years ago. adminSecret or administratorSecret if you want to do Microsofty things. Or mainSecret if you want to follow GitHub's pattern. Or primarySecret, or controlSecret. It takes almost no effort at all to not be crass.

willtong1234 commented 2 years ago

Thank you for the issue. It looks like you have resolved this problem in this issue. Closing this request.

As for the inclusive language, we completely agree with the comment, but are being very careful due to backward compatibility.