aws-samples / aws-serverless-webapp-workshop

Code and walkthrough labs to set up serverless applications for Wild Rydes workshops
https://serverlessland.com
Other
56 stars 151 forks source link

ArcGIS login issue #30

Open robertjsandor opened 2 years ago

robertjsandor commented 2 years ago

Been using this code to teach my beginning AWS students- great project! I've just tested this again and now having problems with the map background not loading. Looks like ArcGIS is requiring a password. After signing in and going to the rides.html page, the page now has a popup showing:

Please sign in to access the item on ArcGIS Online (0e02e6f86d02455091796eaae811d9b5)

Not sure if ArcGIS has made this data private or some other issue. Hopefully someone can let me know what a fix could be. Thanks in advance, Bob

boyney123 commented 2 years ago

Thanks for raising the issue @robertjsandor , I will take a look and get back to you

jeffsec-aws commented 2 years ago

Hi, It is related to the loading of https://js.arcgis.com/4.3/dojo/dojo.js from ride.html

The version 4.3 references the public item ID 0e02e6f86d02455091796eaae811d9b5 while from version 4.5 it points to 92c551c9f07b4147846aae273e822714.

So changing in aws-serverless-webapp-workshop/resources/code/WildRydesVue/src/views/Ride.vue from @import 'https://js.arcgis.com/4.3/esri/css/main.css'; to @import 'https://js.arcgis.com/4.23/esri/css/main.css should solve it.

Cool way to force consumers to update their library dependencies.

Jeff

robertjsandor commented 2 years ago

Bless you!!! Works as designed again!

You saved me from explaining this to a group of struggling students who are putting together the Wildrydes platform architecture as beginners.

Many thanks,

Bob Sandor

Foothill College

From: Jeff Lombardo <> Sent: Wednesday, May 11, 2022 11:01 AM To: aws-samples/aws-serverless-webapp-workshop @.> Cc: robertjsandor @.>; Mention @.***> Subject: Re: [aws-samples/aws-serverless-webapp-workshop] ArcGIS login issue (Issue #30)

Hi, It is related to the loading of https://js.arcgis.com/4.3/dojo/dojo.js from ride.html

The version 4.3 references the public item ID 0e02e6f86d02455091796eaae811d9b5 while version 4.5 points to 92c551c9f07b4147846aae273e822714.

So changing in ride.html from to solves it.

Cool way to force consumers to update their library dependencies.

Jeff

— Reply to this email directly, view it on GitHub https://github.com/aws-samples/aws-serverless-webapp-workshop/issues/30#issuecomment-1124098331 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHKYCOBTKPE7E4KJNMBGW3VJPYT7ANCNFSM5VI5LQ5A . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ABHKYCPDN7IO6GUNKXFWSZTVJPYT7A5CNFSM5VI5LQ5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIMAGCGY.gif Message ID: @. @.> >

jeffsec-aws commented 2 years ago

I am still running some tests. Seems like 4.23 changes the behavior of the Click (from pickup location to zoom in).

I am testing with 4.5 to maintain the initial behavior. I will try to narrow down the best version you go with, but you can start with 4.5.

robertjsandor commented 2 years ago

Thanks- I tried 4.23 but it did not work, I could not place a pin and request a unicorn 😊

4.5 worked fine.

From: Jeff Lombardo <> Sent: Wednesday, May 11, 2022 11:03 AM To: aws-samples/aws-serverless-webapp-workshop @.> Cc: robertjsandor @.>; Mention @.***> Subject: Re: [aws-samples/aws-serverless-webapp-workshop] ArcGIS login issue (Issue #30)

Please note I give 4.5 as example, last version of 4.X branch is 4.23

— Reply to this email directly, view it on GitHub https://github.com/aws-samples/aws-serverless-webapp-workshop/issues/30#issuecomment-1124104138 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHKYCKJESZHGBI236MZBTTVJPY4BANCNFSM5VI5LQ5A . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ABHKYCPPW5GWCCE7DNOTBNDVJPY4BA5CNFSM5VI5LQ5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIMAHPSQ.gif Message ID: @. @.> >

boyney123 commented 2 years ago

Thanks for taking a look @jeffsec-aws, would you recommend we update to 4.5 for now? Or wait until you have found the best version to go for?

I can also take a look, but feels like you have the best context at the moment, let me know if you need any help.

@jeffsec-aws once you are happy are you OK to raise a PR with a fix?

boyney123 commented 2 years ago

Strange, I just ran through the whole thing, tested on Chrome and Firefox and everything seems to be working for me?

I can request unicorns and see them come to my position fine.

I wonder if they have fixed something or not, @robertjsandor or @jeffsec-aws can you try again with the repo version as it is? Could you provide screenshots of the bug, and also the network tab (loading in the resource versions).

Also out of interest what browser versions are you using?

I can't seem to replicate the issue.

pepecuencar commented 2 years ago

Then is css line and script line? It seems to work when i changed css line to 4.5 and script line to 4.5 too, thanks!!!

Trent1900 commented 1 year ago

my one worked on version 4.6. thanks very much, that bothered me for the last 20 hours.