search

aws-samples / aws-serverless-workshop-innovator-island

Welcome to the Innovator Island serverless workshop! This repo contains all the instructions and code you need to complete the workshop.
MIT No Attribution
564 stars 228 forks source link

UPLOAD_BUCKET variable not set in Module 3 #56

Closed nmoutschen closed 3 years ago

nmoutschen commented 3 years ago

Describe the bug

Instructions in the module 3 only retrieve the AWS Region and final bucket, but not the upload bucket (which is needed for subsequent operations in this module. There are instructions in module 1 that sets this variable.

If I run module 3 at a subsequent time or in a new terminal, I won't have the $UPLOAD_BUCKET variable set properly.

Furthermore, instructions in the aforementioned paged ask the user to replace the bucket name manually (aws s3 cp ./green-screen-test.png s3://youruploadbucketname), while the next section uses that variable (aws s3 cp ./green-screen-test.png s3://$UPLOAD_BUCKET).

Link to workshop URL

https://www.eventbox.dev/published/lesson/innovator-island/3-photos/2-backend.html

To Reproduce Steps to reproduce the behavior:

  1. Create a new terminal window
  2. Follow instructions in module 3
  3. Get an error when testing the photo compositing Lambda function

Expected behavior

The UPLOAD_BUCKET should be set at the beginning of module 3.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

jbesw commented 3 years ago

Thanks for raising this issue! https://www.eventbox.dev/published/lesson/innovator-island/3-photos/2-backend.html has now been updated.