search

aws-samples / aws-serverless-workshop-innovator-island

Welcome to the Innovator Island serverless workshop! This repo contains all the instructions and code you need to complete the workshop.
MIT No Attribution
564 stars 228 forks source link

The Instruction Site for Serverless workshop Innovator-island #67

Closed kakaspire closed 3 years ago

kakaspire commented 3 years ago

Describe the bug There are some inconsistencies in the serverless innovator island workshop.

  1. The description "The Flow & Traffic Controller exists in a separate AWS account owned by the theme park. You are provided with the SNS topic ARN to use." in the chapter of "2. Real-time ride wait times - > Backend" seems not correct, need to be rephrase.

The reason is that the lambda "theme-park-ride-times-UpdateRides" is created in the step of "1. Deploy the application - > Backend" to update the Rides information to SNS Topic "theme-park-ride-times-FATcontroller", and the topic is subscribed by another lambda; this is why I think the current description is not correct. Further more, Though "theme-park-ride-times-UpdateRides" is created, it's not mentioned in the architecture diagram.

Link to workshop URL https://www.eventbox.dev/published/lesson/innovator-island/

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://www.eventbox.dev/published/lesson/innovator-island/'
  2. Click on '2. Real-time ride wait times'
  3. Click the sub menu "Backend"
  4. Scroll down to the architecture diagram 'Real-time Serverless Backend' and find the sentence "The Flow & Traffic Controller exists in a separate AWS account owned by the theme park. You are provided with the SNS topic ARN to use."
  5. The sentence is not correct, as the "Flow & Traffic Controller" should be in the same account and should already be created in the previous step of "1. Deploy the application" in this workshop instructor.

Expected behavior The wrong description should be corrected as "A lambda named 'theme-park-ride-times-UpdateRides-XXXXXXXX' is already created in step 1 in the same account and it is triggered by EventBridge(CloudWatch Event) every minute to publish updates to an Amazon SNS topic."

In the meanwhile, It would be good if the CloudWatchEvent and Lambda of UpdateRides can be reflected on the architecture diagrams.

Screenshots

Screen Shot 2021-09-27 at 6 12 23 PM Screen Shot 2021-09-27 at 6 13 04 PM
jbesw commented 3 years ago

Thanks for reporting - I've updated the content.