search

aws-samples / aws-serverless-workshops

Code and walkthrough labs to set up serverless applications for Wild Rydes workshops
http://wildrydes.com
Apache License 2.0
4.2k stars 2.63k forks source link

Removed extra apostrophe to save the public time #165

Closed joetechem closed 5 years ago

joetechem commented 6 years ago

After a bit of re-configuring due to the website not reacting properly (had to be something .js), I was brought to several dead-ends. After ~45min, I noticed an extra apostrophe in config.js Line 8, in the commented example for invokeUrl. Some like me, may test the e.g.; or when getting rid of the e.g., may accidentally leave the stray apostrophe. config.js is used repeatedly for the serverless WebApplication project, so there is a potential for repeated mistakes. Though miniscule, this change could save time and frustration for others like myself.

teknogeek0 commented 5 years ago

HI there, thanks for this and sorry we missed this one. I've gone and applied it to an upcoming PR I have that includes a number of tweaks and fixes that might make this not merge in cleanly. Thanks again for reporting this.