search

aws-samples / aws-tools-for-babylonjs-editor

AWS Tools for Babylon.JS Editor is a suite of tools meant to interact with Babylon.JS Editor by utilizing the capabilities of AWS products.
Apache License 2.0
32 stars 9 forks source link

add real-time printout of spawnsync #15

Closed eherozhao closed 2 years ago

eherozhao commented 2 years ago

Description of changes:

Current git clone cmd in the postinstall script is not including output or error message. By adding stdio, we can get stderr and stdout printed out from the child process to parent process.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

eherozhao commented 2 years ago

Also, could we bring back the comments from the bash script to this node script? They were helpful reminders of why we're running this exact git command, etc

Revised.

eherozhao commented 2 years ago

We should do a merge from live, as the folder structure has changed. Easier to tackle this merge before pushing as PR, than at the moment of merge into main.

I did the git pull of main branch and git rebase main in my local branch. After all auto tests pass, I think it should be fine.