This change adds @amazon-sumerian-hosts/babylon to SceneRequirements.json, where an npm install of that dependency will be run on projects that have Sumerian hosts added to them.
Additionally, since the switch from mainline to mainline2.0 in the Sumerian Hosts repo, the location from where we were pulling/installing assets needed to change.
Other minor fixes:
Formatting of sumerianhost.ts
Because Webpack 5.0 no longer automatically includes util as a polyfill when bundling a project, Webpack complains after the aws-sdk is installed that it can't find this library. It's not strictly necessary - in that the project will still compile and work without this dependency explicitly added - but there's a warning that will show up whenever the project is built that advises this change.
Testing
I tested in the 4.1.1 version of the BabylonJS editor:
I deleted the assets/ directory and ran npm i to ensure the asset retrieval script still worked (mac OSX)
I ran npm build
I created a brand new workspace and went through the new workspace workflow in the BabylonJS Editor
I added a host to the scene
I ran it in the editor, then compiled the project and ran it in the browser
I saved the scene and reloaded it
I again ran it in the editor, and then in the browser
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Description
This change adds
@amazon-sumerian-hosts/babylon
toSceneRequirements.json
, where annpm install
of that dependency will be run on projects that have Sumerian hosts added to them.Additionally, since the switch from
mainline
tomainline2.0
in the Sumerian Hosts repo, the location from where we were pulling/installing assets needed to change.Other minor fixes:
sumerianhost.ts
util
as a polyfill when bundling a project, Webpack complains after theaws-sdk
is installed that it can't find this library. It's not strictly necessary - in that the project will still compile and work without this dependency explicitly added - but there's a warning that will show up whenever the project is built that advises this change.Testing
I tested in the
4.1.1
version of the BabylonJS editor:assets/
directory and rannpm i
to ensure the asset retrieval script still worked (mac OSX)npm build
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.