aws-samples / aws-tools-for-babylonjs-editor

AWS Tools for Babylon.JS Editor is a suite of tools meant to interact with Babylon.JS Editor by utilizing the capabilities of AWS products.
Apache License 2.0
32 stars 10 forks source link

Add @amazon-sumerian-hosts/babylon to project dependencies #22

Closed JuliaABurch closed 2 years ago

JuliaABurch commented 2 years ago

Description

This change adds @amazon-sumerian-hosts/babylon to SceneRequirements.json, where an npm install of that dependency will be run on projects that have Sumerian hosts added to them.

Additionally, since the switch from mainline to mainline2.0 in the Sumerian Hosts repo, the location from where we were pulling/installing assets needed to change.

Other minor fixes:

Testing

I tested in the 4.1.1 version of the BabylonJS editor:

  1. I deleted the assets/ directory and ran npm i to ensure the asset retrieval script still worked (mac OSX)
  2. I ran npm build
  3. I created a brand new workspace and went through the new workspace workflow in the BabylonJS Editor
  4. I added a host to the scene
  5. I ran it in the editor, then compiled the project and ran it in the browser
  6. I saved the scene and reloaded it
  7. I again ran it in the editor, and then in the browser

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.