search

aws-samples / aws-tools-for-babylonjs-editor

AWS Tools for Babylon.JS Editor is a suite of tools meant to interact with Babylon.JS Editor by utilizing the capabilities of AWS products.
Apache License 2.0
32 stars 9 forks source link

Fix: configure CodeQL to ignore docs & dependencies #26

Closed JuliaABurch closed 2 years ago

JuliaABurch commented 2 years ago

Description of changes: This change configures CodeQL so that it is limited only to our source code and not analyzing dependencies.

Additionally, since the Host package has been published to npm, we can remove the part in the workflow that pulls and builds it locally.

Note: you can add debug: true to the CodeQL step, like so:

      - name: Initialize CodeQL
        uses: github/codeql-action/init@v1
        with: 
          config-file: ./.github/codeql/codeql-config.yml
          debug: true

This will generate an archive called debug-artifacts-ubuntu-latest that can be found in the workflow. Unzipped, there is a log available at javascript/log/dataset-import-... that appears to show what files are being looked over. I looked at this to ensure that our project source files were being scanned.

-- By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

eherozhao commented 2 years ago

I was trying to resolve them on the host side but it looks like your solution is more clever.