aws-samples / aws-transcribe-captioning-tools

Convert AWS Transcribe output into multiple caption formats.
MIT No Attribution
93 stars 28 forks source link

getPhrasesFromTranscript leaves out phrase re-edit #5

Closed DavidBelinchon closed 3 years ago

DavidBelinchon commented 5 years ago

If just there are 1 word in las phrase not fill the end-time , I propose this change to fix the bug

Issue #, if available:

2

Description of changes: I save the endtime in a variable and if it's not filled in the last phrase I use the value stored in this variable to fill

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

halfnibble commented 5 years ago

@DavidBelinchon Since these aren't getting merged, can you create your own repo with the fixes you've developed merged into master? Thanks.

halfnibble commented 5 years ago

FYI. I am now maintaining a fork of this repo. Everything will be written for Python3. https://github.com/halfnibble/aws-transcribe-to-srt