Syntax errors when building SDK demo app

[hivemindunit]

Expected behavior and actual behavior

• I walked through the steps described in the deployment guide.
• Windows docker container was never created. I checked the CloudWatch logs, and found the following message in the stderr log: The command 'cmd /S /C call build_zoom_app.bat' returned a non-zero code: 1 An image does not exist locally with the tag: ************.dkr.ecr.us-east-1.amazonaws.com/zoom-virtual-participant-windows
• I tried to build the app locally and multiple build errors fired: Error C2143 syntax error: missing '}' before 'constant' sdk_demo_v2 C:\src\vcpkg\vcpkg\installed\x64-windows\include\smithy\tracing\TraceSpan.h 22
  Error C2059 syntax error: 'constant' sdk_demo_v2 C:\src\vcpkg\vcpkg\installed\x64-windows\include\smithy\tracing\TraceSpan.h 22
  and many more:

Steps to reproduce the problem

• Download the Zoom SDK Sample App
• Install dependencies with vcpgk: crow, aws-sdk-cpp[sns], cpp-jwt
• Apply the patch: https://github.com/aws-samples/aws-virtual-participant-framework-for-rtc/blob/main/virtual-participant-orchestrator-for-zoom-meeting/src/zoom_sdk_demo_v2.patch
• Switch to Release x64 configuration
• Build solution

Specifications like the version of the project, operating system, or hardware

Windows 11, MS Visual Studio 2022 / 2019 Community Edition

[sinasojoodi]

It looks like a vcpkg dependency regression. Can you please verify the same error is popping up in your windows build logs captured in CloudWatch? you want to look at stdout for any build issues. the stderr output is expected (it's trying to load the image from ECR but can't since it was never built before).

Inspect the windows build and container image generation build logs in the latest AWS CloudWatch log stream under the log group beggining with /aws/ssm/PipelineAppStage-CodePipelineCustomActionStack-RunBuildJobOnEc2Instance-

[hivemindunit]

Hey @sinasojoodi, thanks for the reply. As a quick and dirty fix to the above, I just added #undef ERROR at the top of TraceSpan.h source code. I ended up reinstalling VS, vcpkg and the packages, including aws-sdk-cpp.

You were right that I should have looked at the stdout logs. I don't recall what it was exactly, but something unrelated to the issue described above, so closing this one.

[sinasojoodi]

Thanks for letting me know is your issue resolved now?

On Sep 4, 2023, at 8:31 AM, Alex Tsimbalistov @.***> wrote:



Hey @sinasojoodihttps://github.com/sinasojoodi, thanks for the reply. As a quick and dirty fix to the above, I just added #undef ERROR at the top of TraceSpan.h source code. I ended up reinstalling VS, vcpkg and the packages, including aws-sdk-cpp.

You were right that I should have looked at the stdout logs. I don't recall what it was exactly, but something unrelated to the issue described above, so closing this one.

— Reply to this email directly, view it on GitHubhttps://github.com/aws-samples/aws-virtual-participant-framework-for-rtc/issues/34#issuecomment-1705451714, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAEQGEOATZGGWBCFZRFA2L3XYXX25ANCNFSM6AAAAAA3TMV75Q. You are receiving this because you were mentioned.Message ID: @.***>

[hivemindunit]

Yes, @sinasojoodi, thank you!