aws-samples / aws-workshop-for-kubernetes

AWS Workshop for Kubernetes
Apache License 2.0
2.66k stars 1.06k forks source link

Difficult to override defaults in shared AWS account #548

Open mpatters72 opened 6 years ago

mpatters72 commented 6 years ago

During upcoming training session we have 10+ people using the same AWS account. A few simple changes could avoid name collisions.

Cloudformation templates:

lab-ide-build.sh

./create-kubeconfig.sh

Various other places

Other feedback

Cc @cloudymind

dalbhanj commented 6 years ago

Hi @mpatters72

Thanks for feedback on the workshop. I am a little hesitant to propose using single account in a group setting. If we get into that territory, we get into customized delivery of workshop content which is totally up to the speakers/audience if they want to consume it that way. We want to keep this workshop consumption as simple as it can and focus on enabling individual tutorials which is the meat of this workshop. For ex, if customers want to learn how to use Prometheus, Istio/Envoy, Helm charts on top of k8s cluster on AWS, they should find most current information.

I like your suggestion on better separation between kops and non-kops (EKS), and other suggestions like updating env variables. Please send us a PR so we can review it

brianhammons commented 6 years ago

@dalbhanj can you assign this to me? i'm working directly w/ @mpatters72 on these edits.

dalbhanj commented 6 years ago

/assign @cloudymind