search

aws-samples / bedrock-claude-chat

AWS-native chatbot using Bedrock + Claude (+Mistral)
MIT No Attribution
698 stars 240 forks source link

[BUG] Error page is learned when the site accessed by playwright is not HTTP Status 200 #265

Open k70suK3-k06a7ash1 opened 2 months ago

k70suK3-k06a7ash1 commented 2 months ago

Describe the bug

https://github.com/aws-samples/bedrock-claude-chat/blob/02473ad46fc6fc0804d72dc44e75cc0a21cbb39c/backend/embedding/loaders/playwright.py#L156

if response.status != 200:
    raise ValueError(f"page.goto() returned Not HTTP Status 200 for url {url}")

Filling out this field will help us investigate the issue efficiently. Providing detailed information allows us to set the appropriate priority. We appreciate your cooperation.
A clear and concise description of what the bug is.

To Reproduce

Filling out this field will help us investigate the issue efficiently. Providing detailed information allows us to set the appropriate priority. We appreciate your cooperation.
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

statefb commented 2 months ago

@k70suK3-k06a7ash1 Thank you for reporting the issue. Even if 400 or 500 are responded, the task should be succeeded. But error log should be output so that user can debug on it. If you have any good suggestion, please let us know.