search

aws-samples / bedrock-claude-chat

AWS-native chatbot using Bedrock + Claude (+Mistral)
MIT No Attribution
688 stars 232 forks source link

Fix publish API error #353

Closed khchan123 closed 2 weeks ago

khchan123 commented 3 weeks ago

Issue #, if available:

352 (also fix #344)

Description of changes: Fix the leftover DbConfig import which is removed from cdk/lib/constructs/embedding.ts during previous refactor (a3453b42682cb2f247ba7f06b2ed108e965d60ad), in order to fix publish api not working.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

PolicarpoDi commented 3 weeks ago

Thanks for opening the PR.

statefb commented 3 weeks ago

@khchan123 Thank you so much for opening PR! I missed refactoring the api publishment part. #349 could be also solved by adding permission to the handler. Could you also try and add a commit for that please? The secret instance can be constructed like this, and grantRead is needed to add permision like this.

Thank you in advance.

khchan123 commented 3 weeks ago

@khchan123 Thank you so much for opening PR! I missed refactoring the api publishment part. #349 could be also solved by adding permission to the handler. Could you also try and add a commit for that please? The secret instance can be constructed like this, and grantRead is needed to add permision like this.

Thank you in advance.

@statefb fixed in new commit, please approve the PR. Thanks.

statefb commented 2 weeks ago

LGTM, thank you so much for your contribution! closes #349 closes #352 closes #344