search

aws-samples / bedrock-claude-chat

AWS-native chatbot using Bedrock + Claude (+Mistral)
MIT No Attribution
863 stars 311 forks source link

[BUG] Chat Regenerate does not respect websocket preferences #477

Closed ggallo closed 1 month ago

ggallo commented 3 months ago

Describe the bug

If you deploy with WS streaming disabled, requests to regenerate LLM responses will use WS regardless. This is a hazard for customers that need to deploy without WSS due to APIGW lack of private WS APIs.

To Reproduce

  1. Deploy v1.2.7 with VITE_APP_USE_STREAMING = false
  2. Start a conversation and wait for a response
  3. Click Regenerate
  4. Open devtools and notice the request to regenerate goes over WSS

Screenshots

Notice the initial POST, then multiple requests to regenerate are opening WSS connections

image
statefb commented 2 months ago

@ggallo We'll make USE_STREAMING be deprecated because it's hard to maintain the option with keeping backward compatibility to add new features. Thank you for your understanding.

github-actions[bot] commented 1 month ago

This issue has been labeled as "stale" due to no response by the reporter within 1 month (and 14 days after last commented by someone). And it will be closed automatically 14 days later if not responded.

github-actions[bot] commented 1 month ago

This issue has been closed due to no response within 14 days after labeled as "stale", 14 days after last reopened, and 14 days after last commented.