aws-samples / bedrock-claude-chat

AWS-native chatbot using Bedrock + Claude (+Mistral)
MIT No Attribution
915 stars 323 forks source link

Fix compatibility with region inference #531

Closed chm10 closed 2 months ago

chm10 commented 2 months ago

Tested with us-east-1 and will solve issue with EU regions too for Claude Sonnet 3.5.

*Issue #508 and #527

Description of changes: Get the region from BEDROCK_REGION and adapt to cross reference region format.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

statefb commented 2 months ago

@chm10 Hi, thank you so much for creating PR! LGTM except for CI failure (mypy check). Could you create a commit to fix it? (Need to add two spaces before comment)

region = BEDROCK_REGION.split("-")[0] # Cross-region inference
statefb commented 2 months ago

close #508 close #527

statefb commented 2 months ago

LGTM!

statefb commented 2 months ago

@chm10 Sorry, we need to consider following things. Could you re-create a PR including following modification?

Thank you in advance!