search

aws-samples / cdk-eks-karpenter

CDK construct for installing and configuring Karpenter on EKS clusters
Apache License 2.0
37 stars 14 forks source link

helmChartValues.settings overwritten #162

Open ApocDev opened 7 months ago

ApocDev commented 7 months ago

When trying to apply a feature gate value, eg; settings.featureGates.spotToSpotConsolidation, the construct currently overwrites any values because it is not doing a deep merge on objects.

https://github.com/aws-samples/cdk-eks-karpenter/blob/main/src/index.ts#L156-L162

and

https://github.com/aws-samples/cdk-eks-karpenter/blob/main/src/index.ts#L197-L199

andskli commented 6 months ago

Hi @ApocDev, thanks for reporting this. It seems the behavior is undesired. I think what should happen here is that the inverse precedence should happen, i.e. allow helmExtraValues to overwrite what's in helmChartValues. Could you have a look at https://github.com/aws-samples/cdk-eks-karpenter/pull/168?