search

aws-samples / cdk-keycloak

CDK construct library that allows you to create KeyCloak on AWS in TypeScript or Python
Apache License 2.0
89 stars 30 forks source link

Change database removalPolicy to cdk.RemovalPolicy.RETAIN #137

Closed wchaws closed 3 years ago

wchaws commented 3 years ago

123

To solve data lost after upgrading, I think we need to change all database removalPolicy: cdk.RemovalPolicy.RETAIN

https://github.com/aws-samples/cdk-keycloak/blob/11d2b47e6a0293c12b2b1aa40dec850177d7f033/src/keycloak.ts#L333 https://github.com/aws-samples/cdk-keycloak/blob/11d2b47e6a0293c12b2b1aa40dec850177d7f033/src/keycloak.ts#L360 https://github.com/aws-samples/cdk-keycloak/blob/11d2b47e6a0293c12b2b1aa40dec850177d7f033/src/keycloak.ts#L377

github-actions[bot] commented 3 years ago

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon.

github-actions[bot] commented 3 years ago

Closing this issue as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen.