aws-samples / cfn101-workshop

AWS CloudFormation Workshop
https://cfn101.workshop.aws/
MIT No Attribution
159 stars 146 forks source link

Fix s3 regex #188

Closed rezabekf closed 1 year ago

rezabekf commented 1 year ago

What does this PR do and why?

This PR fixes regex for AllowedPatern in Parameters section of various templates.

The new pattern has been inspired by answer from StackOverflow to accommodate AWS documentation on Bucket naming rules

The pattern has been tested here https://regex101.com/r/pwH8T3/1 and test stack has been created to validate the pattern.

Issue #, if available

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

rezabekf commented 1 year ago

Is there somewhere this regex was copied from? If so, can we document where that is?

Good point Chris, I have updated PR description.