search

aws-samples / coast-grafana-cost-intelligence-dashboards

MIT No Attribution
10 stars 2 forks source link

2024 02 11 csaws asg dashboard multi region #30

Closed amazonchris closed 3 months ago

amazonchris commented 5 months ago

*Issue #, if available: https://github.com/aws-samples/coast-grafana-cost-intelligence-dashboards/issues/29

*Description of changes: Updates to Autoscaling Dashboard for multi-region observability of ASG workloads.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

amazonchris commented 3 months ago

  • Remove version from dashboard file name

    • Every Athena datasource should reference the $Datasource variable

    • Reorder the variables so it is clear that ELB and NG depends on Tags

    • Nice to have: while in beta, change the title of the dashboard and the filename to include beta, and maybe keep the Region variable, but only with 'us-east-1' option?

For bullet 2 (Athena Datasource). It seems though when using a mixed datasource panel, Athena will not respect having a variable as a datasource. Cloudwatch works without issue. This seems like a limitation in the Athena datasource plugin.

In this image you see that the panel is mixed, and cloudwatch has a variable. However, selecting ${Datasource} in the Athena datasource yields an error of "Datasource not found"

image
pelgrim commented 3 months ago

In that case, I say let's drop the variable and use the fixed data source name instead, if possible for every data source. It will let us chose the correct data source at import time, correct? And lets discuss further if we should change the default approach to not using data source variables whatsoever.

amazonchris commented 3 months ago

latest commits fix the dashboard name, updated the readme and removed the dashboard datasource variables.