search

aws-samples / coast-grafana-cost-intelligence-dashboards

MIT No Attribution
10 stars 2 forks source link

Import more than one dashboard during deployment #32

Closed sguruvar closed 4 months ago

sguruvar commented 4 months ago

…ards/issues/3

Issue #, if available: https://github.com/aws-samples/coast-grafana-cost-intelligence-dashboards/issues/3

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sguruvar commented 4 months ago

Validated cost/persona dashboards are importing.

Couple points:

  • We'll want to organize these dashboards into separate folders in the future so they have their own readme files and potentially their own cfn files if needed. Not a deal breaker for this change, but we'll want to update this CFN once that happens.
  • for branch naming please use the convention: YYYY-MM-DD-(username)-(issue-description). This will help us weed though the mess of branches once we have more contribution.

Thanks @amazonchris for 1/ I added a new issue which I will be working on.. this is wrt github hygiene of 1 issue per change 2/ am following the fork model .. let me know for any changes required