search

aws-samples / data-lake-as-code

Data Lake as Code, featuring ChEMBL and OpenTargets
MIT No Attribution
166 stars 44 forks source link

updating rds.DatabaseInstanceSourceProps to use credentials #20

Open arozar opened 3 years ago

arozar commented 3 years ago

Description of changes: Currently the Typescript is no longer compiling.

This is due to the fact the the rds.DatabaseInstanceProps interface now uses a credentials property rather than a username and password properties.

Have tested by doing the following:

  1. Code now compiles
  2. Deployed the environment and the SSM run command scripts are now able to use the dbSecrets to seed data in the RDS instances.

Am not able to make this PR to the master branch as the bindingdb stack is not in that branch.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.