aws-samples / data-lake-as-code

Data Lake as Code, featuring ChEMBL and OpenTargets
MIT No Attribution
162 stars 43 forks source link

updating Roda template synth script and fixing rds.DatabaseInstanceProps credentials prop #21

Open arozar opened 3 years ago

arozar commented 3 years ago

Commit 1 - updating Roda table and database names for template synth script

Description of changes: The file SynthRodaTemplates.sh has incorrect naming of glue tables and database names that are created using the Cloudformation stacks that are suggested in comments at the bottom of the script.

Commit 2 - updating rds.DatabaseInstanceSourceProps to use credentials object

Description of changes: Currently, the Typescript is no longer compiling.

This is due to the fact the rds.DatabaseInstanceProps interface now uses a credentials property rather than a username and password properties.

Have tested by doing the following:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.