Fix Column class bug - Githubissues

aws-samples / dbt-glue

This repository contains the dbt-glue adapter

Apache License 2.0

101 stars 69 forks source link

Fix Column class bug #310

Closed sanga8 closed 9 months ago

sanga8 commented 11 months ago

resolves #307

[X] I have signed the CLA
[X] I have run this code in development and it appears to resolve the stated issue
[X] This PR includes tests, or tests are not required/relevant for this PR
[X] I have updated the CHANGELOG.md and added information about my change to the "dbt-glue next" section.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sanga8 commented 11 months ago

@brianhtn

sanga8 commented 10 months ago

@armaseg How could we resolve this bug asap ? It's a breaking change for incremental models. @menuetb

moomindani commented 10 months ago

Currently there is some issue in integ tests (not due to this PR). While we are working on the fix, could you please verify that your PR works fine with integ test? Here's the command.

% python3 -m pytest -s tests/functional/adapter/

sanga8 commented 10 months ago

Currently there is some issue in integ tests (not due to this PR). While we are working on the fix, could you please verify that your PR works fine with integ test? Here's the command.
% python3 -m pytest -s tests/functional/adapter/

Ran the tests, 1 failed, 13 passed, 1 skipped in 989.12s

FAILED tests/functional/adapter/test_snapshot.py::TestSnapshotCheckColsGlue::test_snapshot_check_cols - AssertionError: dbt exit state did not match expected

ParseException: Syntax error at or near '"id"'(line 64, pos 34)

from insertions_source_data as source_data left outer join snapshotted_data on snapshotted_data.dbt_unique_key = source_data.dbt_unique_key where snapshotted_data.dbt_unique_key is null or ( snapshotted_data.dbt_unique_key is not null and ( (snapshotted_data."id" != source_data."id" ----------------------------------^^^

I don't understand yet

moomindani commented 10 months ago

Apologizes for delay. We needed to fix CI/CD pipeline first.

Regarding the original issue this PR was going to solve, I merged the other PR using your commit. https://github.com/aws-samples/dbt-glue/pull/322

For double-quote issue, let me create a separate PR. It will require some fix in test case side.

If you do not have further questions, I am going to close this PR.

moomindani commented 9 months ago

Regarding double-quote issue, https://github.com/aws-samples/dbt-glue/pull/327 is available. Closing this PR.