aws-samples / dbt-glue

This repository contains the dbt-glue adapter
Apache License 2.0
102 stars 69 forks source link

dbt-glue removes double quotes from sql models #311

Closed jausanca closed 10 months ago

jausanca commented 11 months ago

Describe the bug

A change was made on dbt-glue 1.7.0 that removes the double quotes from sql

...
def execute(cls,sql,output=True):
+   sql = sql.replace('"', '')
    if "dbt_next_query" in sql:
...

Don't know if it's intended but it does no longer allow to use double quotes on string literals. But also would remove them even from a string content.

Steps To Reproduce

Run a model containing double quotes for string literals such as

select "foo" as foo from bar

Expected behavior

Double quotes are not removed from the sql